topic Re: CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛 in CMS Development

CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛

douglaswelcome — Fri, 03 May 2019 23:47:44 GMT

CSS is leakin like a sieve. I am targeting

<button>

with my css (using ::before and ::after), but it is leaking out all over the place in rich text editors. Probably happening elsewhere but this is the first place I've seen it.

here's my button:

But now all the menus in rich text editors are getting styled:

Re: CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛

bronson — Mon, 06 May 2019 15:14:30 GMT

The inline editing captabilities within the hubspot CMS rely on the hubspot rich text UI rendering in the same frame as the website content itself.

A good read on best practices to ensure your code works well inside the editor can be found here https://designers.hubspot.com/how-to-make-custom-code-work-with-cms

Re: CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛

Siyabonga — Mon, 06 May 2019 17:39:18 GMT

It looks like the problem here might be that in your css you have targeted button tag which will style all button tags, you need to make sure your style is targeting that one specific element.

Re: CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛

Adesignl — Mon, 06 May 2019 18:40:54 GMT

Do you still need help with this?

Re: CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛

douglaswelcome — Mon, 06 May 2019 18:59:19 GMT

I understand why its happening...just opening up the discussion as to whether it should...

Re: CSS Leak Bug on Rich Text 🐛🐛🐛🐛🐛

Adesignl — Tue, 07 May 2019 00:59:29 GMT

I would say as a general rule you shouldnt style elements only. Well in most cases.

add a class or use a parent selector at least.

That being said hubspots styling should be pretty bullet proof, This happens when people style the button element directly iunstead of only styling the hs-button class instead.

And no it shouldnt.